fix: crash caused by uninitialized discrete vector ptrs on Windows#580
Merged
fix: crash caused by uninitialized discrete vector ptrs on Windows#580
Conversation
ob-robot
force-pushed
the
issue/2026041400115407624
branch
from
7ae954f to
2971f5a
Compare
Co-authored-by: footka <[email protected]>
Co-authored-by: LINxiansheng <[email protected]>
ob-robot
force-pushed
the
issue/2026041400115407624
branch
from
2971f5a to
47c1ad6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
When
ObExpr::init_vectoris called for theVEC_DISCRETEformat, it clears the null bitmap but leaves theptrsandlensarrays uninitialized. For column-reference expressions whereeval_vectoris a no-op, downstream operators (such as sort and window function) read these stale pointers. This causes access violations on Windows, where freed memory is reclaimed more aggressively.Solution Description
The fix zero-initializes the
ptrsandlensarrays withininit_vectorwhen the format isVEC_DISCRETE.Passed Regressions
Core test suite.
Upgrade Compatibility
No specific compatibility concerns noted.
Other Information
Release Note
Fixed an issue where uninitialized vector pointer/length arrays could cause access violations in downstream operators on Windows.